[prometheus-node-exporter] Updated to add k8s service port config #4415
+3
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated prometheus-node-exporter helm chart to allow you to change the Kubernetes service port separately from the container port.
@gianrubio
@zanhsieh
@zeritti
What this PR does
This PR Makes a small change to the prometheus-node-exporter helm chart to allow you to change the Kubernetes service that the helm chart creates and allow you to set the port that the service presents. This change defaults to the current behavior of the chart. This PR adds a new variable that will allow you change the port that the service presents.
Why we need it
If I change service.port to 80 the pods fail to start because of the security context. I do not want to disable the security context. The current behavior is if I change the service.port it also changes the container port to match the service port. The desire is to be able to change only the port number that the service presents and leave the pod configuration at the defaults.
Which issue this PR fixes
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter]
)