Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reexport common types like IntlLangMemoizer and LanguageIdentifier #256

Open
kangalio opened this issue Jun 11, 2022 · 2 comments
Open

Reexport common types like IntlLangMemoizer and LanguageIdentifier #256

kangalio opened this issue Jun 11, 2022 · 2 comments
Labels
crate:intl-memoizer enhancement good first issue Want to help? Those are great bugs to start with! help wanted We need help making decisions or writing PRs for this.

Comments

@kangalio
Copy link

It's slightly annoying to have to depend on third-party crates just to be able to interact with fluent-rs itself.

So far in my journey of exploring fluent, I have to depend on intl-memoizer to be able to spell out the fluent::bundle::FluentBundle<fluent::FluentResource, intl_memoizer::concurrent::IntlLangMemoizer> type. Though I was able to work around depending on unic_langid by creating a LanguageIdentifier via .parse() instead

@gregtatum
Copy link
Member

Seems reasonable enough to me to export the IntlLangMemoizer since it's part of this repo. I'm less sure of the LanguageIdentifier, especially since you can opt into macro usage.

@gregtatum gregtatum added enhancement help wanted We need help making decisions or writing PRs for this. good first issue Want to help? Those are great bugs to start with! labels Nov 7, 2022
@alerque
Copy link
Collaborator

alerque commented May 6, 2024

LangIdentifier in particular is a bit mixed up because it turns up in inic-langid and fluent-langneg as well, and the implementations are not currently in sync. That sync issue is separate for this (c.f. fluent-langneg-rs#26 and I also agree with Greg that it may not make sense to export it.

Contributions still welcome for IntlLangMemoizer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate:intl-memoizer enhancement good first issue Want to help? Those are great bugs to start with! help wanted We need help making decisions or writing PRs for this.
Projects
None yet
Development

No branches or pull requests

3 participants