Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent scans from scanning dupe templates #4690

Open
rxerium opened this issue Jan 26, 2024 · 6 comments · May be fixed by #4817
Open

Prevent scans from scanning dupe templates #4690

rxerium opened this issue Jan 26, 2024 · 6 comments · May be fixed by #4817
Assignees
Labels
Type: Enhancement Most issues will probably ask for additions or changes.

Comments

@rxerium
Copy link

rxerium commented Jan 26, 2024

Hi there,

When pointing scans to a custom templates folder using the -t flag, Nuclei does not remove duplicate templates. Could we include a mechanism which stops the scan from scanning the same template twice?

Thanks

Rishi

@rxerium rxerium added the Type: Enhancement Most issues will probably ask for additions or changes. label Jan 26, 2024
@mastercho
Copy link

There is dupe templates in official repo too, so this will make skip lots

@dogancanbakir dogancanbakir self-assigned this Jan 29, 2024
@dogancanbakir
Copy link
Member

@rxerium,
Could you please provide an example? Are you referring to duplicating entries with the same id?

@rxerium
Copy link
Author

rxerium commented Feb 27, 2024

Yup I am.

Its primarily when users save their own templates to a folder and the ID is the same it scans the same template twice.

@dogancanbakir dogancanbakir linked a pull request Feb 28, 2024 that will close this issue
4 tasks
@mastercho
Copy link

b7fd0d462edee6014f67d0334611d7c7
I thought you mean dupe like this one

@rxerium
Copy link
Author

rxerium commented Feb 28, 2024

That's the same thing no? The template ID is the same

@mastercho
Copy link

Well before template ID was as CVE then projectdiscovery/nuclei-templates#9065 after this issue was renamed to wp-user-enum but for some reason renamed templates doesnt rename in local cloned repo, instead creates new template (when updating template from nuclei run) and we end up with dupe templates with different ID's, i have reported that last year but never been looked at from PD perspective. There lots of templates like that which i point from time to time in Discord when i notice dupes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants