Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation for calico CNI binaries does not work anymore #8818

Closed
DockToFuture opened this issue May 14, 2024 · 0 comments · Fixed by #8827
Closed

Validation for calico CNI binaries does not work anymore #8818

DockToFuture opened this issue May 14, 2024 · 0 comments · Fixed by #8827

Comments

@DockToFuture
Copy link

DockToFuture commented May 14, 2024

Expected Behavior

All calico binaries should be installed or an error should be returned.

Current Behavior

Calico binaries are not properly installed and no error is returned.

Problem

With #8517 the behaviour was changed how the installation of the CNI binaries is verified. Instead of executing 'calico -v', a check is executed if the calico binary was copied successfully.
The destinationUptoDate function contains a check which returns false and nil if the size of the binaries differ. This leads to a running calico-node pod which is not properly working due to potentially corrupt binaries.
In our case the calico binary was not completely copied, see the following logs:

root@xxx:/opt/cni/bin# ls -la
total 122104
drwxr-xr-x 2 root root     4096 May 14 09:41 .
drwxr-xr-x 3 root root     4096 May 14 09:40 ..
-rwxr-xr-x 1 root root  4046172 May 14 09:40 bandwidth
-rwxr-xr-x 1 root root 41377792 May 14 09:40 calico
-rwxr-xr-x 1 root root 62171883 May 14 09:40 calico-ipam
-rwxrwxr-x 1 root root  2491863 May 14 09:41 flannel
-rwxr-xr-x 1 root root  3522445 May 14 09:41 host-local
-rwxr-xr-x 1 root root  3603570 May 14 09:41 loopback
-rwxr-xr-x 1 root root  4040630 May 14 09:41 portmap
-rwxr-xr-x 1 root root  3763475 May 14 09:41 tuning

Context

Your Environment

  • Calico version: 3.27.3
  • Orchestrator version (e.g. kubernetes, mesos, rkt): kubernetes
  • Operating System and version:
  • Link to your project (optional):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants