New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial: ByteArray thoughts #156

Open

lauckhart opened this issue May 21, 2023 · 1 comment

Assignees

Labels

Collaborator

lauckhart commented May 21, 2023

Some quick ideas r.e. ByteArray.

Right now we monkeypatch Uint8Array, might be frowned upon by some library users
Could we make ByteArray a subclass of Uint8Array instead of an alias, and put utility functions there?
We could also add custom toString and toJSON methods so diagnostics like in Resuming a Session the second time fails #138 would show as hex rather than comma-separated decimal
I could also add the base64 utilities using the codec I made for the security stuff

Collaborator

Apollon77 commented May 21, 2023

@mfucci introduced it that way. I think the idea was that on other platforms it might nbe something else then UInt8Array, thats why "just" the alias.

@mfucci Any opinion on this?

Apollon77 added the question label

lauckhart self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment