Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel: attempt inviting before errorring about needing at least half/op to invite someone #1482

Open
Mikaela opened this issue Jul 17, 2021 · 1 comment

Comments

@Mikaela
Copy link
Contributor

Mikaela commented Jul 17, 2021

In several IRCds there are modes that allow everyone to invite users. On Ergo IRCd (which inspires opening this issue), free-invite is the default (without any modes) and thus Limnoria should just invite me to room on command, not complain to me that it needs halfop to do it (which is wrong). It can always see when there is a real error about the invite and then complain afterwards.

  • The current (running) version of this Limnoria is 2021.07.16, running on Python 3.9.2 (default, Feb 28 2021, 17:03:44) [GCC 10.2.1 20210110]. The newest versions available online are 2021.06.15 (in master), 2021.07.16 (in testing).

  • ergo-2.7.0
@progval
Copy link
Owner

progval commented Jul 17, 2021

Depends on #1483 (yes I opened that issue just because of this, but it has been on my mind for a while)

Relationale:

This would mean trying INVITE and waiting for ERR_CHANOPRIVSNEEDED from the server to send the error to the user. Unfortunately, this can't be done reliably without labeled-response, because many other events may cause ERR_CHANOPRIVSNEEDED at the same time, and that numeric doesn't have enough info to match what message caused it.

Because labeled-response handling in Limnoria is currently very clunky (see the REGISTER implementation in Services...), I'm unlikely to implement this before #1483 is resolved, as it provides a good way to implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants