-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix modal to not shift/move the page upon closing #737
Labels
Comments
If it can help, you can have a look at the sources of Material-UI around how the library solves this issue. |
@oliviertassinari Thanks, that's an excellent suggestion! It seems like Material's modal has the behavior we want (at least in the context of their docs site), so I'll have to see what we can do to get closer to their implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using the Modal component from
pcln-modal
on another application I noticed the page body shift to the left when closing the modal. This is something that can also be seen on priceline.com.The text was updated successfully, but these errors were encountered: