-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add style and script tag #83
Comments
Since this is already be possible right now where the only work that needs to be done to support this is on the Renderer ( on the consumer side), I don't think there's anything we need to do on Reka itself(?) |
Yeah, adding it to the Renderer is no big deal. It's more of a question if this should be added to the main branch or if users of reka should add that feature themselves. Imho the addition would spare the users time to figure it out theirselves and point towards a possible direction. That's what the Renderer is for anyway i assume |
Feature proposal style & script tag
Improvement:
Stylesheet Management, a solution for #44
CSS Animations without external deps.
Executing custom JS.
Currently reka.js has the text value
If right now one adds a script or style-tag and tries to insert a text value a span is inserted which is not how they work.
By adding the corresponding tags to the renderer they are usable.
Problems:
Adding either of those tags will open up for XSS.
Right now they're pretty safe as they cannot be used by default.
Otherwise:
An anchor tag can already be prepared with a malicious link for clickjacking.
I have both of those already running and can create a PR.
The text was updated successfully, but these errors were encountered: