Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VimuxOpenRunner doesn't work any more #225

Open
matawed opened this issue Feb 27, 2024 · 7 comments
Open

VimuxOpenRunner doesn't work any more #225

matawed opened this issue Feb 27, 2024 · 7 comments

Comments

@matawed
Copy link

matawed commented Feb 27, 2024

It seems that my nvim/vimux setup is broken with #217. If I run VimuxOpenRunner it silently fails, meaning that no terminal is opened.

Once I revert this change locally, my setup works again, meaning that terminal is opened as expected.

Tmux version 3.0a/ Ubuntu 20.04

@matawed
Copy link
Author

matawed commented Feb 27, 2024

Will provide more details upon request/once I have more time to check details.

@mvanderkamp
Copy link
Member

Some more details would be helpful, can you share your configuration?

@matawed
Copy link
Author

matawed commented Feb 27, 2024

Steps to reproduce on Ubuntu 20.04 with tmux 3.0a

cd ~/.vim/
mkdir -p pack/vimux/start
git clone https://github.com/preservim/vimux

vim -V9/tmp/vim.txt

produces

vim.log

if you do

:VimuxOpenRunner

The problematic command is

tmux split-window -l 20% -v

See

image

@matawed
Copy link
Author

matawed commented Feb 27, 2024

Though -l size seems to be supported

image

but seems to be only for absolute values

image

@matawed
Copy link
Author

matawed commented Feb 28, 2024

Naive approach for fixing this issue is to check the exit code of this command and if it fails then issue the other command. I guess, it would be helpful in any case to check exit code and not only silently fail in this case. What do you think?

@mvanderkamp
Copy link
Member

Ahh, thank you. I think I'll put a conditional in there based on the tmux version.

@mvanderkamp
Copy link
Member

You know what... should we just say that it's up to the user to decide whether to include the percent sign? This will be a bit of a hiccup when the plugin is updated, since setting let g:VimuxHeight = "20" will have to change to let g:VimuxHeight = "20%".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants