Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dispatch({ type: actionTypes.CLEAR_DATA }) does not clear 'queries' and 'composite' #418

Open
benomatis opened this issue Feb 7, 2022 · 2 comments · May be fixed by #421
Open

dispatch({ type: actionTypes.CLEAR_DATA }) does not clear 'queries' and 'composite' #418

benomatis opened this issue Feb 7, 2022 · 2 comments · May be fixed by #421

Comments

@benomatis
Copy link

While 'data' and 'ordered' do clear, 'queries' and 'composite' (both contain actual data) remain using dispatch({ type: actionTypes.CLEAR_DATA }) and even after unsetting all listeners.

I found no way to clear them other than reloading the page - not very elegant.
@benomatis benomatis linked a pull request Feb 14, 2022 that will close this issue
Open
@benomatis
Copy link
Author

I tested the fix I introduced in PR #421 but it's not actually working - I don't understand the code enough to be able to know why, so if anyone interested in having this solved, and can help fixing it, I'd be happy to get corrected. Thanks.

@benomatis
Copy link
Author

I tested the fix I introduced in PR #421 but it's not actually working - I don't understand the code enough to be able to know why, so if anyone interested in having this solved, and can help fixing it, I'd be happy to get corrected. Thanks.

It's working now - I forgot to build the package.

@benomatis benomatis changed the title dispatch({ type: actionTypes.CLEAR_DATA }) does not clear 'queries' and 'composite' dispatch({ type: actionTypes.CLEAR_DATA }) does not clear 'queries', 'composite' and 'cache' May 2, 2023
@benomatis benomatis changed the title dispatch({ type: actionTypes.CLEAR_DATA }) does not clear 'queries', 'composite' and 'cache' dispatch({ type: actionTypes.CLEAR_DATA }) does not clear 'queries' and 'composite' May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: CLEAR_DATA to clear composite and queries as well benomatis/redux-firestore
1 participant
@benomatis