-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#convert_to_text misses closing a
tag when no href
is present but other attributes are
#404
Comments
sounds about right, pr welcome ... most likely just missing a |
@grosser i have a fix but i don't have access rights, do i have to push to a fork or something? |
make a fork
…On Wed, May 12, 2021 at 10:36 AM Ryan Campbell ***@***.***> wrote:
@grosser <https://github.com/grosser> i have a fix but i don't have
access rights, do i have to push to a fork or something?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#404 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACYZ3G7OLEP4BDSWBG27TTNK4DLANCNFSM44XD5GBQ>
.
|
This was referenced May 12, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The string
"<a attr=\"attr\">foo</a><a href=\"test.com\">bar</a>"
, when run throughconvert_to_text
, returnsbar ( test.com )
(omitting thefoo
part entirely). I think this is because the regexes fora
tags in#convert_to_text
are missing everything between<a
and thehref
in the SECONDa
tag.For comparison,
"<a>foo</a><a href=\"test.com\">bar</a>"
(removingattr=\"attr\"
) returnsfoobar ( test.com )
. The regex skips the firsta
tag entirely.The text was updated successfully, but these errors were encountered: