Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all launcher args as optional in the Helm charts #465

Open
tgaddair opened this issue May 9, 2024 · 0 comments
Open

Add all launcher args as optional in the Helm charts #465

tgaddair opened this issue May 9, 2024 · 0 comments
Assignees
@magdyksaleh
Labels
enhancement New feature or request

Comments

@tgaddair
Copy link
Contributor

tgaddair commented May 9, 2024

Currently we only support a subset of LoRAX launcher args. We should support all of them as optional overrides:

https://github.com/predibase/lorax/blob/main/charts/lorax/templates/deployment.yaml#L35
@tgaddair tgaddair added the enhancement New feature or request label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magdyksaleh magdyksaleh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tgaddair @magdyksaleh