Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve async load for adapters to avoid main thread lockups in server #457

Open
tgaddair opened this issue May 3, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@tgaddair
Copy link
Contributor

tgaddair commented May 3, 2024

The concurrency currently assumes that host execution time that holds the GIL is minimal, but particularly for loading adapters from disk to host memory, we see that large adapters can lock up the server.

This could in part be addressed by #434 which goes direct to GPU from disk with minimal host memory copying. We could also explore options like CUDA streams and pinned memory if needed to further optimize the load.

@tgaddair tgaddair added the enhancement New feature or request label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant