-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move wmr.cjs to wmr.js (esm) #963
Comments
What is the use case for loading this via a CDN? It's a 2mb CLI. |
I could use it over reejs URL imports, basically URL imports for nodejs & bun (and works alongside with deno ofc). Also is there any reason why you're still bundling cjs and not esm though? Pretty sure nodejs can do much better with esm. |
Why would you be importing it at all though? As mentioned, it's a CLI, generally not something you'd ever want to import.
This repo hasn't seen any development in a couple years, if you hadn't noticed. Node 12 was the original release target and it did not have great ESM support (though module format is mostly irrelevant for a CLI).
I'm not quite sure what you think would be better? |
If the cli binary is converted into esm format, it would make it easier for URL imports, making the world a better place to live in. Well maybe that was an exaggeration, but atleast it would make https://esm.sh work.
Currently neither https://cdn.jsdelivr.net/npm/wmr/wmr.cjs/+esm works nor https://esm.sh/wmr/wmr.cjs works.
Considering nodejs now supports esm, it would be better to make the code ready for the future 😁
The text was updated successfully, but these errors were encountered: