-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ambiguities with create command usage #1523
Comments
Sounds reasonable. Feel free to submit a PR or something, otherwise I'll take a look when I get a block of time. I think I'll want to check over the other commands too just to make sure everything is matching up correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Do you want to request a feature or report a bug?
This proposal aims at changing the current behavior of the
create
command.What is the current behaviour?
As specified in the docs, the
create
command expects thetemplate-name
andproject-name
(required arguments). However, the current implementation treats them as optional arguments.preact-cli/packages/cli/lib/index.js
Line 44 in 4acc8c7
If the current behaviour is a bug, please provide the steps to reproduce.
preact-cli/packages/cli/lib/commands/create.js
Lines 209 to 214 in 4acc8c7
The current implementation checks for a --template flag, which doesn't exist; hence the prompt to choose preactjs-template shows up even though it is specified.
preact-cli/packages/cli/lib/commands/create.js
Lines 81 to 87 in 4acc8c7
What is the expected behaviour?
--template
flag.--name
flag is not required.Please mention other relevant information.
N/A
The text was updated successfully, but these errors were encountered: