Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IoT-Spot : LED Blinking using RaspberryPI #351

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

IoT-Spot : LED Blinking using RaspberryPI #351

wants to merge 3 commits into from

Conversation

mukundsolanki
Copy link
Contributor

Related Issue

  • Basic task would be writing a program with RaspberryPI support to blink the LED.

  • IWOC2.0 2024 Participant

  • Contributor

Closes: #342

Describe the changes you've made

Added the LED Blinking code with RaspberryPi using Python while following the project structure + also written a documentation for all the changes

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

@prathimacode-hub prathimacode-hub added IWOC2024 These issues are specifically created for IWOC participants Easy Easy Peasy Issues to Work Upon labels Jan 17, 2024
@prathimacode-hub prathimacode-hub changed the title Basic led blinking using raspberry pi IoT-Spot : LED Blinking using RaspberryPI Jan 17, 2024
prathimacode-hub
prathimacode-hub reviewed Jan 17, 2024
View reviewed changes
Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue mentions using Raspberry Pi but here you had worked using ESP8266 and given the same project structure and title accordingly. But issue you got assigned is different from the PR submitted. Kindly look into it. @mukundsolanki

@prathimacode-hub prathimacode-hub added the Request Changes Changes mentioned should be addressed label Jan 17, 2024
@mukundsolanki
Copy link
Contributor Author

Okay 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prathimacode-hub prathimacode-hub prathimacode-hub left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@mukundsolanki mukundsolanki

Labels
Easy Easy Peasy Issues to Work Upon IWOC2024 These issues are specifically created for IWOC participants Request Changes Changes mentioned should be addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IoT-Spot : LED Blinking using RaspberryPI
2 participants
@mukundsolanki @prathimacode-hub