Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video Merger #1099

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Video Merger #1099

wants to merge 5 commits into from

Conversation

ambushneupane
Copy link

@ambushneupane ambushneupane commented Oct 5, 2022 •
edited

Related Issue

  • A python script to Merge Many videos into a single Video

  • Hacktoberfest2021 Participant

  • Contributor

Closes: #1100

Describe the changes you've made

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

The script has been tested the script on my local machine for different test cases.

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly whereever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream module

@welcome
Copy link

welcome bot commented Oct 5, 2022

Hello there! 👋 Welcome to the project! 💖
Thank you and congrats 🎉 for opening your first pull request. Please adhere to our Code of Conduct. 🙌🏻 We will get back to you as soon as we can. 😄

Feel free to get in touch with me through social media handles. Hope to see you there!😄

@prathimacode-hub
Copy link
Owner

First create an issue using issue template, add issue details and get it assigned. Then work on it. And while creating PR, add PR template along with PR details and issue number as a commit message. Follow the contributing guidelines. @ambushneupane

@ambushneupane ambushneupane mentioned this pull request Oct 5, 2022
Open
@prathimacode-hub
Copy link
Owner

Don't work on issue without getting merged. First sort the issue fixings. Use PR template as a commit message along with issue details and issue number in it. @ambushneupane

@ambushneupane
Copy link
Author

So what am I supposed to do? Can you provide me the correct procedure for successful PR?

@prathimacode-hub
Copy link
Owner

Add a PR template provided as a commit message, include issue details and issue number while creating PR. You can refer to this PR as a sample : #1097. You will get better clarity and once you read the contributing guidelines and readme file for PR file format structure. @ambushneupane

@prathimacode-hub prathimacode-hub added the HACKTOBERFEST This issue is applicable for Hacktoberfest 2022 label Oct 6, 2022
@ambushneupane
Copy link
Author

Hey Thanks For assigning. Since I have already done the PR, what should I do to get it merged?

@prathimacode-hub
Copy link
Owner

Add PR template in the commit message above with issue details and issue number to review the PR. @ambushneupane

@ambushneupane
Copy link
Author

Hey I have Edited Can you have a look on it?

prathimacode-hub
prathimacode-hub requested changes Oct 8, 2022
View reviewed changes
Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to be done :

Add comments in code to get good understanding of the file
Follow the README template provided and elaborate it accordingly
Keep the project title as "Video Merger"
Give script file names in snake case format except README.md

@ambushneupane

@prathimacode-hub prathimacode-hub added the Request Changes Requesting for changes in PR label Oct 8, 2022
@ambushneupane ambushneupane changed the title Add Video Merger Video Merger Oct 8, 2022
@ambushneupane
Copy link
Author

Hey I have made changes you asked for Can you have a look on it?

prathimacode-hub
prathimacode-hub requested changes Oct 15, 2022
View reviewed changes
Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elaborate your README file briefer.
Keep the project title as "Video Merger"

These changes aren't done yet. @ambushneupane

@ambushneupane
Copy link
Author

Added some Description How to Keep my Project Name as Video Merger?

@prathimacode-hub
Copy link
Owner

You can rename the file from your forked repository and push the changes again. @ambushneupane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prathimacode-hub prathimacode-hub Awaiting requested review from prathimacode-hub

Requested changes must be addressed to merge this pull request.

Assignees

@ambushneupane ambushneupane

Labels
HACKTOBERFEST This issue is applicable for Hacktoberfest 2022 Request Changes Requesting for changes in PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Video Merger
2 participants
@ambushneupane @prathimacode-hub