Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preact-async-route does not play well with preact-router + preact-transition-group #12

Open
fantasia949 opened this issue Oct 29, 2017 · 3 comments

Comments

@fantasia949
Copy link

This fiddle is to reproduce the issue.
When trying it, you will notice the async route's transition class is not removed properly.

This link references to this issue.

@austinjp
Copy link

Hi there. Is there any news on this? After a day of scratching my head over preact router transitions, I noticed this behaviour, and some Googling led me here. 😃

@prateekbh
Copy link
Owner

Hi! sadly no, I haven't been able to get to work on this. And due to the nature of how AsyncRoute is implemented, it'll might be tough to tell the wrapper which component is to be transitioned

@austinjp
Copy link

Thanks @prateekbh . I'm having a look at your liquid-route and transition-challenge for inspiration instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants