Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Waybar Select Menu similar to Rofi Style Select Menu #1300

Open
saulback opened this issue Apr 13, 2024 · 8 comments
Open
Labels
enhancement New feature or request

Comments

@saulback
Copy link

Feature Request

Description

MOD + Shift + B (or other key combination) will open a waybar select menu where you can see previews of all the possible waybar options, similar to how wallpapers, themes, rofi all have a select menu. User can than select the desired waybar.

Use Case

Currently to select the desired waybar layout, you have to MOD + ALT + down/up until you find the one you are looking for. Each time selecting the new waybar takes some time. Looking at the default config.ctl, there are 24 different options that you would need to go through. So, especially for a beginner, they would have to navigate through all 24 to identify the one they liked most, then keep navigating through to finally land on the one they wanted.

A menu would make this process drastically easier. A user would just open the menu and be able to see all the possible options and directly select the one they want without having to cycle through every one.

Proposed Solution

First, it seems to me that there probably aren't 24 distinct layouts. There are probably around 6 different layouts that go either top, bottom, right, left. So I think we could have 2 sections of the menu, 1 where you select where you want the waybar - top, left, right or bottom. Then another section where you select from the 6-ish layouts.

In the config.ctl, we could specify the preview image to use for each line. The files would live in a preview folder in the same directory.

Alternatives

I haven't considered alternatives.

Additional Information

[Add any other information about the feature request here. For example, you might include links to similar features in other projects, or screenshots or diagrams to help explain your idea.]
For examples, see the Wallpaper/Rofi/Theme selector menus.

@saulback saulback added the enhancement New feature or request label Apr 13, 2024
@kRHYME7
Copy link
Collaborator

kRHYME7 commented Apr 13, 2024

Good Idea, but we should take note that these layouts can be changed/added/deleted by the user having a preferred layout.
If the layout changes then the Rofi menu will be useless and can lead to confusion.

  • Alt 1 (the best) Dynamically draw the layout upon rofi menu execution.
  • Alt 2 Make a static and pre-configured waybar config.json and style .css that is forever bound to the rofi menu modes. And should be separated from the control file.
  • Alt 3 Pre generate the waybar configuration without overwriting the current one ( You will spawn a secondary waybar ) will take effect upon confirmation.

@dieBakterie
Copy link
Contributor

Yeah that's an amazing Idea.

@dieBakterie
Copy link
Contributor

We can Go them through the config.ctl and doing Like an diaoshow?

@prasanthrangan
Copy link
Owner

prasanthrangan commented Apr 15, 2024

Hi, this is possible in theory...

First, it seems to me that there probably aren't 24 distinct layouts. There are probably around 6 different layouts that go either top, bottom, right, left. So I think we could have 2 sections of the menu, 1 where you select where you want the waybar - top, left, right or bottom. Then another section where you select from the 6-ish layouts.

the layouts in config.ctl was just to show the possibilities, and its not predefined... users can add as many layouts as they can think of, with different modules/order/position/size/groups as they like.

In the config.ctl, we could specify the preview image to use for each line. The files would live in a preview folder in the same directory.

this would be a nightmare to create an image for each line, so the only way is to make it dynamic.
but to make the previews dynamic and modular, each module should have its own svg/png (the hardest part).
then it will be easy to group these images based on the layouts/lines in config.ctl to show a preview for each line.

@dieBakterie
Copy link
Contributor

Yeah sorry haven't thought how complex and hard to implement this would be.

@prasanthrangan
Copy link
Owner

prasanthrangan commented Apr 15, 2024

Yeah sorry haven't thought how complex and hard to implement this would be.

No worries, I think it can be done...
But first, need to have svg images for each available (25) modules, to generate previews for each layout on the fly.

backlight
battery
bluetooth
cliphist
clock
cpu
cpuinfo
gpuinfo
idle_inhibitor
keybindhint
language
memory
mpris
network
power
pulseaudio
spotify
taskbar
theme
tray
updates
wallchange
wbar
window
workspaces

@rubiin
Copy link
Contributor

rubiin commented Apr 19, 2024

we can also include the default svgs for waybar on the readme too

@its-19818942118
Copy link

I think adding this for lock screen or sddm would be great. But it will be too much work though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants