Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Negative number of questions #112

Open
nishita2104 opened this issue May 20, 2023 · 3 comments · May be fixed by #131
Open

[BUG] Negative number of questions #112

nishita2104 opened this issue May 20, 2023 · 3 comments · May be fixed by #131
Assignees
@nishita2104
Labels
bug Something isn't working level1

Comments

@nishita2104
Copy link

Describe the bug
The web app asks infinite questions if a negative number of questions is entered.

To Reproduce
Steps to reproduce the behavior:

  1. Go to main page
  2. Click on 'Let's Start'
  3. Scroll down to 'number of questions'
  4. Enter a negative number, say, -1.
  5. Click 'get set go', then 'start now'.
  6. The app keeps asking questions infinitely.

Expected behavior
It should've displayed an error when an invalid number of questions are entered.

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows
  • Chrome
  • Version 113

I can fix this by adding a check on the number of questions and displaying an error message wherever required. Please assign this to me under GSSoC'23.
@nishita2104 nishita2104 added the bug Something isn't working label May 20, 2023
@prakhartiwari0
Copy link
Owner

Oh nice one @nishita2104, thanks for pointing that out, I am assigning you the issue. Feel free to ask questions whenever you need to.

Happy Contributing!

@prakhartiwari0
Copy link
Owner

We need to set a bar that the user can't enter a number below 1, so see what can be done.

@nishita2104
Copy link
Author

Thank you for assigning it to me.

@nishita2104 nishita2104 linked a pull request May 22, 2023 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nishita2104 nishita2104

Labels
bug Something isn't working level1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Neg num of ques nishita2104/Arito
2 participants
@prakhartiwari0 @nishita2104