Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP request error handling #115

Open
rudigiesler opened this issue Jan 25, 2017 · 0 comments
Open

Add HTTP request error handling #115

rudigiesler opened this issue Jan 25, 2017 · 0 comments

Comments

@rudigiesler
Copy link
Contributor

Currently, when making an HTTP request to an external service, we check the response code, and log the appropriate error if the response code isn't good.

This does not account for the case where the connection gets closed before a status code is sent, or for any other related http error.

We should catch the error and do the correct thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant