-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Mistakes in Ch4/01_OnePipeline_ManyClassifiers.ipynb #75
Labels
bug
Something isn't working
Comments
Okay, not sure that went wrong here. Let me look into this over the weekend. |
Okay it seems to be an error on our side. @kgdunn would you want to send a pr to fix this? |
I'm using your code and notebooks to learn from. I doubt you'd want a PR
from me in this context.
…On Sun, 29 Aug 2021, 09:58 Varun P, ***@***.***> wrote:
Okay it seems to be an error on our side. @kgdunn
<https://github.com/kgdunn> would you want to send a pr to fix this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#75 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAENGT3VHJBGUTHV3LEYZMLT7HSC7ANCNFSM5CM3H7BQ>
.
|
On the contrary, I believe that this would be another learning opportunity. |
This issue is resolved in PR #133 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In: Ch4/01_OnePipeline_ManyClassifiers.ipynb
1/ In cell 14, related to SVM: there is a copy/paste error in the comment, referring to Logistic regression, when the code in that cell is only regarding SVM.
2/ The AUC metric calculated here for SVM calculates something, but it is the AUC for the prior cell, for logistic regression. As seen by the duplicated values.
The text was updated successfully, but these errors were encountered: