Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing images #262

Open
afilp opened this issue Feb 27, 2023 · 2 comments
Open

Missing images #262

afilp opened this issue Feb 27, 2023 · 2 comments

Comments

@afilp
Copy link

afilp commented Feb 27, 2023

There are missing images here:

https://github.com/practicajs/practica/blob/main/docs/docs/decisions/monorepo.md

image

@goldbergyoni
Copy link
Contributor

@afilp Welcome and sorry about the late reply

These docs are meant to be consumed from practica.dev site:
https://practica.dev/decisions/monorepo

Have to find a way to make 'em consumable via GitHub as well 🥺

@vishal-sharma-369
Copy link

I think the links to the image source are broken

Error: In the monorepo.md file :

the link to the full.png file in the img tag is : /img/docs/decisions/full.png
the link to the partial.png file is : /img/docs/decisions/partial.png
the link to the almost-full.png file is : /img/docs/decisions/almost-full.png

Solution:
the link to the full.png file should be : /docs/static/img/docs/decisions/full.png
similarly:
the link to the partial.png file should be : /docs/static/img/docs/decisions/partial.png
the link to the almost-full.png file should be : /docs/static/img/docs/decisions/almost-full.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants