Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DockerfileCUDA102 #101

Closed
wants to merge 1 commit into from
Closed

Add DockerfileCUDA102 #101

wants to merge 1 commit into from

Conversation

pyun-ram
Copy link

@pyun-ram pyun-ram commented Oct 8, 2022

Description of the change

Description here

Type Of Change

  • Bug Fix (non-breaking change that fixes an issue)
  • New Feature
  • New PyTorch tutorial
  • Breaking Change (cmake changes, fix or feature that would cause existing functionality to not work as expected)

Related Issues

Fix #100

Development & Code Review

  • cpplint rules passes locally (run cmake -P cpplint.cmake)
  • CI is passing
  • Changes have been reviewed by at least one of the maintainers

@mfl28
Copy link
Collaborator

mfl28 commented Jan 3, 2023

IMHO it would make more sense to extend the the current Dockerfile to include the functionality of building for/running on GPU. Then we could keep the extra features of our docker_entrypoint.sh.

@prabhuomkar prabhuomkar closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prabhuomkar prabhuomkar Awaiting requested review from prabhuomkar prabhuomkar is a code owner

@mfl28 mfl28 Awaiting requested review from mfl28

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] Dockerfile to support CUDA-version pytorch-cpp
3 participants
@pyun-ram @mfl28 @prabhuomkar