Large banana showers cause significant lag when loaded during gameplay

[snalgae]

Type

Performance

Bug description

I decided to investigate the cause of this lag because it has affected 2 of my plays on a map. I managed to isolate this lag to the banana shower. It is consistent and a long enough banana shower by itself can produce it.
Here's the map if you need it: https://osu.ppy.sh/beatmapsets/2138244#fruits/4500030

Screenshots or videos

2024-05-19.23-56-49.mp4

Version

2024.519.1

Logs

compressed-logs.zip

[bdach]

This is still a problem despite https://github.com/ppy/osu/pull/9664/files because the banana shower in question has ~250 nested bananas which overflows the pool.

osu/osu.Game.Rulesets.Catch/UI/CatchPlayfield.cs

Line 89 in dedc2d2

RegisterPool<Banana, DrawableBanana>(100);

I'm not sure what the way out is here. It's either

• better (map-dependent?) initial pool capacity
• don't retrieve all of the bananas from pool immediately (and return them on judgement)
• something else?

the first of which is probably both easiest and simplest. @ppy/team-client thoughts welcome

[smoogipoo]

Yeah, that PR was a bit of a best effort because DHOs don't have a lifetime management container and all that.

Not sure of an immediate solution, but I'd move towards "don't retrieve all of the bananas from pool immediately" with the future refactoring/rework of hitobject lifetime management.

[bdach]

Randomly found #12659, which this is a duplicate of.