Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use v1/bootstrap if Connect version supports it #594

Open
nealrichardson opened this issue May 22, 2024 · 3 comments
Open

Use v1/bootstrap if Connect version supports it #594

nealrichardson opened this issue May 22, 2024 · 3 comments

Comments

@nealrichardson
Copy link
Contributor

As this endpoint comes out of experimental, we should switch to the new endpoint depending on the version of the Connect server we're talking to.

@aronatkins
Copy link
Collaborator

The 2024.05.0 release includes POST /__api__/v1/bootstrap. The POST /__api__/v1/experimental/boostrap endpoint is deprecated and scheduled for removal with 2024.12.0.

rsconnect-python should start using the /v1/ API for Connect 2024.05.0 and newer, using the /v1/experimental/ API for older versions until they pass beyond the support horizon (18mos from 2024.04.0).

@aronatkins
Copy link
Collaborator

A challenge for this particular endpoint: the internal server_settings API is used to obtain the Connect version, but server version is not provided to unauthenticated requests.

@nealrichardson
Copy link
Contributor Author

Hmm, then do we have to

try:
    POST /__api__/v1/bootstrap
except:
    POST /__api__/v1/experimental/bootstrap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants