Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake not rebuilding external apps when baseband code is changed #2025

Open
NotherNgineer opened this issue Mar 23, 2024 · 2 comments · Fixed by #2031
Open

Cmake not rebuilding external apps when baseband code is changed #2025

NotherNgineer opened this issue Mar 23, 2024 · 2 comments · Fixed by #2031
Labels
bug Something isn't working

Comments

@NotherNgineer
Copy link
Contributor

NotherNgineer commented Mar 23, 2024

Describe the bug.

When a baseband module is changed that is used by an external app and firmware is rebuilt, the external app needs to be regenerated to include the updated baseband module.

Reproduction

  1. Modify a baseband module such as tone_gen.cpp.
  2. Run "make"
  3. Note that baseband modules are recompiled, but external apps were not rebuilt with the new baseband modules.

Expected behavior

External apps need to be rebuilt if a baseband module is changed.

Environment/versions

No response

Anything else?

Should be a simple makefile change to add a dependency, but just documenting the issue right now.

@NotherNgineer NotherNgineer added the bug Something isn't working label Mar 23, 2024
@gullradriel
Copy link
Member

I got hit by it when trying your PR

@NotherNgineer
Copy link
Contributor Author

The makefile change in PR #2031 didn't work properly, so reopened this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants