-
-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updateDom in createDom function #40
Comments
updateDom方法貌似只是用来处理dom元素的一些attributes以及一些事件绑定,创建了dom以后不就应该即可绑定属性、事件吗?而且updateDom里的逻辑也不存在把dom挂载到页面的行为,应该没问题吧? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I don't understand why we excute 'updateDom' in the function 'createDom'.It seems that we would change the dom before 'commit',and that should not happen in 'performUnitOfWork'
The text was updated successfully, but these errors were encountered: