-
-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"DELETION" exception #30
Comments
hi there, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
commitWork
function, when enteringDELETION
condition judgment,it shouldruturn
;) } else if (fiber.effectTag === "DELETION") { domParent.removeChild(fiber.dom) + return } commitWork(fiber.child) commitWork(fiber.sibling) }
Otherwise
didact
will repeatedly delete child elements, and will throw a exception:Here is my test code
The operation effect is as follows:
Test it on codesandbox
I open a PR to fix the question
The text was updated successfully, but these errors were encountered: