Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: support for dialog-polyfill? #2768

Open
IndependentCreator opened this issue Aug 11, 2023 · 1 comment
Open

Feature request: support for dialog-polyfill? #2768

IndependentCreator opened this issue Aug 11, 2023 · 1 comment

Comments

@IndependentCreator
Copy link

What

Add support for https://github.com/GoogleChrome/dialog-polyfill

This would be nice to have to help us start using the <dialog> element with more confidence.

Details

I see that this was requested back in 2017 and at the time the response was

We would need to ensure that the polyfill is filling for a standard feature of the web platform, which we're not sure is the case here.

Has the opinion of the maintainers changed in 2023 now that <dialog> is more widely supported?
https://caniuse.com/?search=dialog
https://www.scottohara.me/blog/2023/01/26/use-the-dialog-element.html
https://webkit.org/blog/12209/introducing-the-dialog-element/

@ScottAwesome
Copy link

Biggest issue I could see with this is it isn't a "set it and forgot" thing. You have many limitations when using the Dialog polyfill. For instance, when using the polyfill, you have to register each dialog element with the polyfill, as well as additional limitations

Of course this could be surfaced this to users, however the polyfill also doesn't handle focus management which needs to be explained as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants