Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array.findLast() does not seem to be available #2734

Open
lehni opened this issue Jan 28, 2023 · 7 comments
Open

Array.findLast() does not seem to be available #2734

lehni opened this issue Jan 28, 2023 · 7 comments
Labels
service Relates to an Origami service

Comments

@lehni
Copy link

lehni commented Jan 28, 2023

Four months ago, Array.findLast() was added to the polyfill-library:

https://github.com/Financial-Times/polyfill-library/tree/master/polyfills/Array/prototype/findLast

But in the URL builder, it is nowhere to be found:

https://polyfill.io/v3/url-builder/

And when I fetch the polyfill.js file on a browser that does not support the function, e.g. Firefox v103, I don't find its definition in the returned polyfill:

https://polyfill.io/v3/polyfill.js?features=all

What am I missing?

@origamiserviceuser origamiserviceuser added this to Backlog in Origami ✨ Jan 28, 2023
@github-actions github-actions bot added the service Relates to an Origami service label Jan 28, 2023
@JakeChampion
Copy link
Collaborator

We have not updated the polyfill-library version used in polyfill.io, this is why you have not been able to get a polyfill for this feature

@lehni
Copy link
Author

lehni commented Jan 29, 2023

Thanks for clarifying. May I ask why it hasn't been updated?

@pathikrit
Copy link

pathikrit commented Mar 12, 2023

Same for findLastIndex - this was added in JakeChampion/polyfill-library#1230 more than 7 months ago but is not available. Please update polyfill? Thank you!

@lehni
Copy link
Author

lehni commented Mar 13, 2023

We ended up self-hosting the library on an AWS lambda… polyfill.io is heavily lagging by now.

@JakeChampion
Copy link
Collaborator

I'll be updating it in a few weeks, it's a breaking change though, requires more work than you may realise

@pathikrit
Copy link

@JakeChampion: Looking forward! And, thank you for polyfill!

@robertboulton robertboulton removed this from Backlog in Origami ✨ Jul 26, 2023
@mustafa0x
Copy link

mustafa0x commented Sep 16, 2023

We ended up self-hosting the library on an AWS lambda… polyfill.io is heavily lagging by now.

Any idea where I can find self host instructions?

This blog post seems out of date since I don't see start_server.sh: https://golb.hplar.ch/2018/01/Self-host-Polyfill-io.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service Relates to an Origami service
Projects
None yet
Development

No branches or pull requests

4 participants