Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Intl locales to the url builder page #2147

Closed
wants to merge 1 commit into from

Conversation

JakeChampion
Copy link
Collaborator

This is one way to resolve #1911

If someone has another solution to this problem, please comment on this PR :-)
image

@JakeChampion JakeChampion requested a review from a team as a code owner February 26, 2020 13:34
@origamiserviceuser origamiserviceuser added this to incoming in Origami ✨ Feb 26, 2020
@chee
Copy link
Contributor

chee commented Feb 26, 2020

a long cat with all the internationalisation settings

@notlee
Copy link
Contributor

notlee commented Feb 26, 2020

Seems like the old solution was reasonable, to show one result with a little note
Screenshot 2020-02-26 at 13 54 32

@JakeChampion
Copy link
Collaborator Author

@notlee It was okay but it did not list all the locales the user can choose from, they would have to hazard a guess

@notlee
Copy link
Contributor

notlee commented Feb 26, 2020

@notlee It was okay but it did not list all the locales the user can choose from, they would have to hazard a guess

How many are there? I wonder if they could be listed in the note. Not searchable but avoids the long long list so other available polyfills can be scanned

@JakeChampion
Copy link
Collaborator Author

@notlee It was okay but it did not list all the locales the user can choose from, they would have to hazard a guess

How many are there? I wonder if they could be listed in the note. Not searchable but avoids the long long list so other available polyfills can be scanned

716

@chee
Copy link
Contributor

chee commented Feb 26, 2020

Could we have it show as something like Intl.PluralRules.~locale.LOCALE and have the word LOCALE be bold and the hover note says For valid locales see <the supported locales page> and we have another page that lists all the valid locales at like https://polyfill.io/v3/supported-locales

@chee
Copy link
Contributor

chee commented Feb 26, 2020

Actually, that does kind of interrupt the ability to use the polyfill builder.
What about if we have a ▶ Intl.PluralRules.~locale expander, and all the locale checkboxes appear loaded in when you toggle the expander?

@JakeChampion JakeChampion added feature New feature request website Relates to an Origami website labels Mar 24, 2020
@JakeChampion JakeChampion marked this pull request as draft April 10, 2020 01:22
Origami ✨ automation moved this from incoming to complete Jul 14, 2020
@JakeChampion JakeChampion deleted the intl-website branch July 27, 2020 10:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2021
@robertboulton robertboulton removed this from Done in Origami ✨ Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature request website Relates to an Origami website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intl and Locale Documentation missing in v3 website
3 participants