Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IV in catch message/reformat catch message. #271

Open
WitherredAway opened this issue Jul 25, 2021 · 8 comments
Open

IV in catch message/reformat catch message. #271

WitherredAway opened this issue Jul 25, 2021 · 8 comments

Comments

@WitherredAway
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Showing the IV of the caught pokemon when one is caught would be a nice touch. Additionally, it would reduce load on the bot to some extent since there wouldn't be as many 'p!i 0's.

Describe the solution you'd like
Maybe something like (a) this or (b) this. I personally prefer (a) because it looks cleaner.

I can code this, but I won't proceed without approval from oli. Also feel free to criticize/give opinions on the catch messages shown in the above links.

@pikaninja
Copy link
Contributor

Sometimes it's better to keep the text short though, ie to keep flood down, I feel the catch message should be short and not embeded, though the second one looks fine to me 🤷

@WitherredAway
Copy link
Collaborator Author

understandable, the embed has another issue: it won't ping unless the message outside the embed has the @ so that might look messy. the second one is cool too, but maybe there's a way to reformat it to make it look nicer and less confusing. I'm out of ideas tho, so feel free to send some my way if you have any :D

@pikaninja
Copy link
Contributor

I mean another format we could look into is like "You caught a level 1 Pikachu(100% iv)!" Or something, or even make the display iv an option the way silence is

@oliver-ni
Copy link
Member

i don't think this needs to be embedded

@ooys
Copy link
Contributor

ooys commented Aug 6, 2021

I mean another format we could look into is like "You caught a level 1 Pikachu(100% iv)!" Or something, or even make the display iv an option the way silence is

Hmm... maybe a Rich Catch Notifications option. Are there other custom settings that we could add along with this?

@WitherredAway
Copy link
Collaborator Author

WitherredAway commented Aug 6, 2021

I had another idea: depending on if their catch mention is on or not, the bot will ping. e.g.
if member.catch_mention: await ctx.send(message) else: await ctx.send(message, allowed_mentions=discord.AllowedMentions.none())

This way it'll prevent the bot from pinging others if you have <@ id> in your name with id being someone else's id.

As for the catch message itself, I think a hybrid of (b) and what pikaninja said could work:
Congratulations Witherr! You caught a Ralts! (Level 1, IV 100%)
or just what pikaninja said, I think that's clean too if you wanna keep the Level where it currently is. Also, what did you mean by Rich Catch Notification?

@WitherredAway
Copy link
Collaborator Author

Could we have a conclusion to this please 🤔

@staticaron
Copy link

staticaron commented Mar 23, 2022

image
TBH, this looks neat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants