Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poerm_grpc: Use metadata of Status structure in headers #791

Open
maksimtor opened this issue Apr 1, 2024 · 1 comment
Open

poerm_grpc: Use metadata of Status structure in headers #791

maksimtor opened this issue Apr 1, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@maksimtor
Copy link

Currently in poem_grpc we have structure Status which contains metadata. And also we have GrpcServer that uses Status::to_headers() method to extend response headers. This method does not use its metadata, and I actually can't see where we use Status metadata at all.
When I want to send error response in form of Status, I would like to send additional headers and I can't do it now. Can we consider using metadata from Status to send additional headers in response? Or if we don't want it, can we create additional field like 'custom_headers' in Status in order to retrieve them for use in response headers? It seems to be a small feature and I can make PR if idea is okay.

@maksimtor maksimtor added the enhancement New feature or request label Apr 1, 2024
@sunli829
Copy link
Collaborator

Welcome PR, I would like to add a custom_headers method to Status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants