New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pnpm:devPreinstall is not run when shared-workspace-lockfile is false #4503
Labels
Comments
It turns out the issue caused by this line setting
in shared-workspace-lockfile=false setting, which in turn disabled pnpm:devPreinstall in this linepnpm/pkg-manager/core/src/install/index.ts Line 313 in 9719a42
|
alvis
added a commit
to alvis/pnpm
that referenced
this issue
Apr 29, 2024
When `shared-workspace-lockfile` is false, opts.ignoreScripts is set to true since packages are rebuild after recursive install. However, it will cause `pnpm:devPreinstall` to be skipped as well since it's not part of the rebuild process. This fix fixes the issue by checking whether the --ignore-scripts flag is set from the source instead fix pnpm#4503
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
pnpm version:
6.32.3
Code to reproduce the issue:
.npmrc
:package.json
:pnpm-workspace.yaml
:Expected behavior:
pnpm i
runs./my-command
Actual behavior:
pnpm i
does not run./my-command
. But ifshared-workspace-lockfile
is enabled, it does. I would have expected it to work in both cases, and there doesn't seem to be anything in the docs to suggest otherwise.Additional information:
node -v
prints:v16.14.0
The text was updated successfully, but these errors were encountered: