You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I had a thought that that could save worker minutes, and allow contributors to get feedback faster.
How would people feel about on a PR CI the configuration being set to use jests --changedSince flag. That means we could on a PR change diff just with main and run the appropriate tests for just the change code areas --changedSince="main"
This means that the CI run time should be considerably faster, and hopefully a bit less flakey. Which would allow contributors to get faster feedback on their changes?
We could also have it run a full suite on approval of a code review which would mean that all code is run through a full test run before it is merged.
It should be a fairly simple change in the CI.yml to make sure that the master branch is downloaded too, and an if statement to add the flag.
Then we could add an additional on action for code approval, and trigger a full CI run without the flag, or have it in a separate workflow
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I had a thought that that could save worker minutes, and allow contributors to get feedback faster.
How would people feel about on a PR CI the configuration being set to use jests --changedSince flag. That means we could on a PR change diff just with main and run the appropriate tests for just the change code areas
--changedSince="main"
This means that the CI run time should be considerably faster, and hopefully a bit less flakey. Which would allow contributors to get faster feedback on their changes?
We could also have it run a full suite on approval of a code review which would mean that all code is run through a full test run before it is merged.
It should be a fairly simple change in the CI.yml to make sure that the master branch is downloaded too, and an if statement to add the flag.
Then we could add an additional
on
action for code approval, and trigger a full CI run without the flag, or have it in a separate workflowThanks
Beta Was this translation helpful? Give feedback.
All reactions