Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Mappings for _api/navigation/menuState #1257

Open
1 task done
JakeStanger opened this issue Aug 17, 2023 · 2 comments
Open
1 task done

API Mappings for _api/navigation/menuState #1257

JakeStanger opened this issue Aug 17, 2023 · 2 comments
Labels
area: model 📐 Related to the core SDK models

Comments

@JakeStanger
Copy link

Category

  • Feature request

Describe the feature

There are some SP navigation settings that can only be set via the _api/navigation/menuState and _api/navigation/saveMenuState REST API. Currently these are not nicely exposed via PnP Core.

Describe the solution you'd like

As a minimum, It should be possible to get and save the menu state directly, using built-in PnP Core methods.

Ideally, some of the options should also be exposed via the regular navigation, with PnP Core automatically switching endpoint accordingly. For example, the "open in a new tab" option should be settable on NavigationNodeOptions, and then the library will use saveMenuState instead of the 'regular' web navigation endpoint.

Additional context

PnP PowerShell implementation for Add-PnPNavigationNode cmdlet, which aligns with the above:
https://github.com/pnp/powershell/blob/ccee58d064da543e40a4a7a872ad9574f8a108ed/src/Commands/Navigation/AddNavigationNode.cs#L125

@jansenbe jansenbe added the area: model 📐 Related to the core SDK models label Aug 17, 2023
@jansenbe
Copy link
Contributor

@JakeStanger : that would make sense as a change. Is this something you could take on?

@JakeStanger
Copy link
Author

Possibly, but it wouldn't be short-term nor something I could commit to I'm afraid.

I will likely need a solution to this for a work project in a few weeks, so time constraints will control whether I can add something in here or not. I'll do my best to keep you updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: model 📐 Related to the core SDK models
Projects
None yet
Development

No branches or pull requests

2 participants