Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve GroupId from #1216

Open
1 task done
plamber opened this issue Jun 26, 2023 · 2 comments
Open
1 task done

Retrieve GroupId from #1216

plamber opened this issue Jun 26, 2023 · 2 comments
Assignees
Labels
area:admin 📜 Admin library related

Comments

@plamber
Copy link
Contributor

plamber commented Jun 26, 2023

Category

  • Domain model extension

Describe the domain model extension

Would it be possible to extend the ISiteCollectionWithDetails object with additional properties? One that I am looking for is the GroupId to identify site collections that have a group id associated. I am sure there are other properties that could be interesting.

Is it ok to extend these methods or should we query the tables directly?

Thank you for your feedback,
Patrick

@jansenbe
Copy link
Contributor

@plamber : you can add more properties for ISiteCollectionWithDetails but keep in mind that underlying we're querying 2 hidden lists in tenant admin (see https://github.com/pnp/pnpcore/blob/dev/src/sdk/PnP.Core.Admin/Model/SharePoint/Core/Internal/SiteCollectionEnumerator.cs#L90-L143). The added properties should be available in both lists as otherwise the resulting output will not be complete.

Alternative approach, but did not research this, can be #1113

@jansenbe jansenbe added the area:admin 📜 Admin library related label Jun 26, 2023
@plamber
Copy link
Contributor Author

plamber commented Jun 27, 2023

Hello,
I wanted to share my initial excitement when I came across the information, but unfortunately, the list DO_NOT_DELETE_SPLIST_TENANTADMIN_ALL_SITES_AGGREGATED_SITECOLLECTIONS does not provide the desired GroupId output.

In light of this situation, I believe it would be beneficial for us to investigate issue #1113 and consider maintaining the current endpoints unchanged. @MathijsVerbeeck, I was wondering if you have any valuable insights regarding the progress made on this matter?

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:admin 📜 Admin library related
Projects
None yet
Development

No branches or pull requests

2 participants