romio: Fix wrong communicator use in ADIOI_GEN_OpenColl #6884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ADIOI_GEN_OpenColl is called in ADIO_CREAT mode, file creation is done by calling ADIOI_xxx_Open with MPI_COMM_SELF by rank == fd->hints->ranklist[0]. If successful, the file is closed with ADIOI_xxx_Close, and later the file will be opened by all without creation flag. The problem is that the communicator of ADIOI_GEN_OpenColl is passed to ADIOI_xxx_Close instead of MPI_COMM_SELF. If a collective call is made using this communicator in ADIOI_xxx_Close, it may hang.
|
test:mpich/authorship |
|
test:mpich/authorship |
My MPICH idivisual cla is still stuck on the mailing list ([email protected]) waiting for moderator approval. |
We got your cla. You are all set. |
|
test:mpich/ch3/most |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
When ADIOI_GEN_OpenColl is called in ADIO_CREAT mode,
file creation is done by calling ADIOI_xxx_Open with MPI_COMM_SELF by rank == fd->hints->ranklist[0].
If successful, the file is closed with ADIOI_xxx_Close, and later the file will be opened by all without creation flag.
The problem is that the communicator of ADIOI_GEN_OpenColl is passed to ADIOI_xxx_Close instead of MPI_COMM_SELF.
If a collective call is made using this communicator in ADIOI_xxx_Close, it may hang.
Fixes: #6868
Contribution Agreement
I have sent the MPICH Individual Contributor License Agreement by e-mail and am awaiting approval.
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.