Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement disk cache for large split packet reassembly #145

Open
dktapps opened this issue Apr 17, 2022 · 0 comments
Open

Implement disk cache for large split packet reassembly #145

dktapps opened this issue Apr 17, 2022 · 0 comments

Comments

@dktapps
Copy link
Member

dktapps commented Apr 17, 2022

The current max split size is problematic for Minecraft usage due to extremely oversized skins. It's also problematic to increase it due to exposing servers to denial-of-service attacks.

A workaround for this would be to cache parts of very large split packets (above a certain threshold) on disk temporarily, so that RAM doesn't get exhausted trying to reassemble huge splits for many sessions at the same time. Since disk space is typically more abundant than RAM, this would allow a higher limit on split count, which would alleviate some issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant