Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to discern BMP instance peer distinguisher and route distinguisher if both are present? #783

Open
GeorgyKirichenko opened this issue May 13, 2024 · 1 comment

Comments

@GeorgyKirichenko
Copy link

Description
As I discovered bmp daemon outputs Peer Distinguisher (PD) from Per-Peer header as rd and rd_origin fields of dumping object. However, bgp route also may have a route distinguisher (RD) with the same output field names.

So I am afraid, then in case if both PD and RD are present there would be a little mess inside bmp daemon output.

Also I would suggest to rename Peer Distinguisher output name to pd.

We use 1.7.6 version of pmacct

WBR

@paololucente
Copy link
Member

Hi @GeorgyKirichenko ,

Thanks for bringing this up & apologies for the late answer.

In principle, we could certainly have two different fields for pd and rd. If you would have some code to contribute, please i'd be happy to receive a PR; I would also be curious about two aspects (which we can cover here or by unicast email):

  • your real use-case scenario on how pd and rd are differing;
  • we should take into account correlation of BMP with, say, IPFIX. The PD ending up in the RD field in internal structures does help with that; are you correlating BMP with flows? Or are you instead running pmbmpd?

Paolo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants