-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JupyterLab settings not respected #1010
Comments
Actually, another way to recreate is just to untick the settings in the Jupyterlab extensions settings, then open a new notebook,. The new notebook displays the buttons. If you then tick and untick then tick the settings, the button remains, disappears, reappears. So the decision to decide whether or not to display a button when the notebook is opened is broken, JupyterLab Version 4.2.0 |
thanks, we'll look at this in the meantime, you can try uninstalling jupysql-plugin after installing jupysql, that should remove both buttons |
Note: we fixed the "share notebook" button. we're working on a fix for the "format SQL" (they're in different repos) making a new release of ploomber-extension shortly |
What happens?
Initialising a new jupyterlab environment with default settings to disable the display of the
Share notebook
andFormat SQL
toolbar buttons, the settings are not respected although the settings editor describes them correctly.Enabling then disabling the setting from the settings panel does then correctly hide the buttons.
To Reproduce
I used the following settings:
In
.jupyter/lab/user-settings/ploomber-extension/settings.jupyterlab-settings
:In
.jupyter/lab/user-settings/jupysql-plugin/settings.jupyterlab-settings
:Start the jupyter server, open a notebook, and the buttons are displayed.
OS:
Linux Ubuntu
JupySQL Version:
0.10.10
Full Name:
Tony Hirst
Affiliation:
The Open University
The text was updated successfully, but these errors were encountered: