Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display error icon on error #96

Open
pbogre opened this issue Jun 29, 2023 · 2 comments
Open

display error icon on error #96

pbogre opened this issue Jun 29, 2023 · 2 comments

Comments

@pbogre
Copy link

pbogre commented Jun 29, 2023

I tried uploading some files and the upload kept failing because they were too large (i had to check the post request response through the developer settings in the browser)

turns out the problem was small client_max_body_size in my nginx configuration, but i think it would be helpful if instead of display the green checkmark icon when uploads like this fail, it displayed an error icon and maybe even the http response.

i wouldn't have been as confused if each time i tried uploading a file and it didn't show up i saw an error icon rather than a green checkmark

@pldubouilh
Copy link
Owner

ha it's very good to know, I'll dig into that - thanks for the report !

would you mind sharing the nginx config used ? I'll also mention it on the docs.

@pbogre
Copy link
Author

pbogre commented Jun 30, 2023

Sure, here's the section that dealed with gossa in my nginx.conf:

    # Gossa
    location /gossa {
      return 302 http://$host/gossa/;
    }
    location /gossa/ {
      proxy_pass http://gossa:8001/gossa/;
    }

and here's the line that i added at the top of my configuration to allow large upload files (i chose 100 MB as the max size, but it can be set to 0 to have no limits)

    # increase maximum request size
    client_max_body_size 100M;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants