-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concatenation issue #1133
Comments
I think that works as expected given all preloaded scripts will be included in the concatenated script file. Does setting preload = false to the worker script fix this? That's the proposed way to treat worker script files on production builds too. There is rarely a reason to preload worker scripts since the worker will request the files separately. |
Yes, it works correctly without concatenation. In our production builds, we download non-concatenated build and concatenate/minify it ourselves, so we have a control over what is concatenated. Still could be useful in Launcher, when the project has many scripts, as loading is much faster with concatenated option in that case. Perhaps a boolean property could be added to script asset to be excluded from concatenation. Edit: |
Creating worker fails, when Launcher is started with "Concatenate Scripts" option:
Related forum: https://forum.playcanvas.com/t/new-worker-causing-build-fail/35411
Repro: https://playcanvas.com/project/1204252/overview/concatenation-issue
The text was updated successfully, but these errors were encountered: