-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
investigate if we need to worry about duplicate sheet ids #110
Comments
@daniel-shuy I had a quick look at the old code and I don't think it makes any sense unless there is an xlsx that demos the issue. The input stream should come from the packagePart - this allows for the new code to reparse the sheet data because it can get a new input stream from the packagePart. I'm happy to put a warning in the release notes and if anyone runs into an issue and provides a demo xlsx, I can add a test case and modify the code as needed. As it stands the code in the main branch is messy with (for me) no proven reason why it needs to be like that. |
#107 (comment)
The text was updated successfully, but these errors were encountered: