Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_video(): add parameters for fps and output destination #21

Open
mkornacker opened this issue Oct 5, 2023 · 0 comments
Open

make_video(): add parameters for fps and output destination #21

mkornacker opened this issue Oct 5, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@mkornacker
Copy link
Collaborator

mkornacker commented Oct 5, 2023

  1. fps parameter:
  • make_video() currently produces videos at a fixed 25 fps.
  • instead, it should accept an optional parameter (default: 25, or maybe 30) 'fps' which will be applied at runtime.
  1. skip None frames
  2. specify output destination:
  • currently, .mp4 files are written into the current directory
  • add kw parameter for the output destination (which could be a local directory or a prefix for an external URL such as an S3 bucket) and write it there
@mkornacker mkornacker added the good first issue Good for newcomers label Oct 5, 2023
@mkornacker mkornacker changed the title make_video() with fps parameter make_video(): add parameters for fps and output directory Nov 25, 2023
@mkornacker mkornacker changed the title make_video(): add parameters for fps and output directory make_video(): add parameters for fps and output destination Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant