-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please do not hardcode libc++
#3518
Comments
What should the relevant line be instead, to work in the most places? Can you propose a fitx in a PR? |
@gojomo Can it be made conditional on Clang being used (i.e. not GCC)? That would solve the problem, since Clang on macOS always uses I can confirm that a build with GCC does not need |
I'm not an expert on MacOS build options - even though MacOS is my primary system, when using/building Gensim, I'm almost always doing it on Linux VMs. So I can't imagine what your proposal would mean in the changed file(s), or evaluate it with my own judgement. But, a concrete PR could be auto-verified as still passing tests, still creating successful official MacOS wheel builds, and then (via testimony of yourself & others) recommended as also better in less-common/non-official-wheel build environments. |
@gojomo I will see how to make |
Currently
-stdlib=libc++
flag is passed unconditionally on macOS.Ref: https://github.com/piskvorky/gensim/blob/develop/setup.py
This is undesirable, since while Apple does use
libc++
starting from 10.7, hardcoding it unnecessarily breaks compilation againstlibstdc++
.The text was updated successfully, but these errors were encountered: