New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convex shape validator fails to validate bucket shape #224
Comments
Okay I think I figured it out. When constructing a Polygon, it'll generate the convex hull and strip out the remaining points. So in my screenshot, just points 1, 6, 7, 8 will remain. This all happens before It seems like the |
I only find one testbed example where this is used, I guess this was made to test the conversion code (rather than validate user input). Anyway, if you would like please free to make a pull request and convert it to a static method. |
Example code:
Screenshot of the points on a coordinate plane:
This is not a convex shape, but for some reason the validator says it is. This might be related to #218 although I am not repeating my start/end points so there is probably a different issue.
The text was updated successfully, but these errors were encountered: