-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Homebrew formula #5
Comments
Let's go! I'll let you know when things are done! |
Oh, I didn't realize Pipelight wasn't cross-platform. Would you accept a PR highlighting that in the README? |
Also, are there any plans to make Pipelight cross-platform? Nothing in the description seems like its Linux-specific- I'm curious what Linux features Pipelight uses that aren't in MacOS or Windows |
Thank you I will make it explicit in the doc. TODO: Add warnings in documentation linux only. I explain in detail how it works there: https://pipelight.dev/introduction/description.html |
Yes of course PR are absolutly welcomed |
At the time I wrote the biggest part of the code, the modules(crates) responsible for managing processes were not compatible with other OS than Linux. But it seems things have changed recently with sysinfo and rustix. Some workaround will be needed for Windows,.. but I think MacOS might finally work!! |
I'm not a rust dev, but if I check it out, can I run |
Yes of course. Try building the binary and run a command. cd <repo_path>
cargo run --bin pipelight ls I am updating the CONTRIBUTING.md |
Unfortunately, the
|
What a shame! I usually try to keep dependencies clean! |
@pipelight , It seems like
|
Sorry! My bad again! I pushed to the wrong repo! |
haha you caught me just before I turned off my Mac - now I'm getting several warnings that look much easier to deal with (mostly
|
Same for me here! I was just about to prepare for sleep! Which version of cargo and rustup are you on? rustup -V
cargo -V |
I renamed the module to a name that is not taken by a rust standard library module. Pushed the changes to dev! For real this time! |
$ rustup -V
rustup 1.26.0 (5af9b9484 2023-04-05)
info: This is the version for the rustup toolchain manager, not the rustc compiler.
info: The currently active `rustc` version is `rustc 1.70.0 (90c541806 2023-05-31)`
dev 18:02:41.947 PST mac02:~/Git-GH/pipelight
$ cargo -V
cargo 1.70.0 (ec8a8a0ca 2023-04-25) I was able to build After updating:
Here's the compilation output (still some unused import errors, but I get a binary!)
|
Still interested in providing a Homebrew formula for macOS? I'm not sure how to do it for Rust (I use GoReleaser - GoReleaser for my Go ClIs). |
Amazing!! |
I can not test the formula myself! |
I'm happy to assist to get this working on Windows. |
I think that it could run in WSL... |
Building failed on compiling signal-hook-registry. (on the master branch)
|
Ok, i will replace this dependencie with one compatible with windows |
I'd love to be able to manage upgrades and such with Homebrew.
The text was updated successfully, but these errors were encountered: