Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup spec does not have nodeSelector field #5319

Open
yiduoyunQ opened this issue Oct 9, 2023 · 0 comments
Open

Backup spec does not have nodeSelector field #5319

yiduoyunQ opened this issue Oct 9, 2023 · 0 comments

Comments

@yiduoyunQ
Copy link
Contributor

yiduoyunQ commented Oct 9, 2023

Bug Report

What version of Kubernetes are you using?

What version of TiDB Operator are you using?

Current all version

What storage classes exist in the Kubernetes cluster and what are used for PD/TiKV pods?

What's the status of the TiDB cluster pods?

What did you do?

Deploy Backup

What did you expect to see?
Backup spec can configure nodeSelector just like TiDB-Cluster spec, see
https://github.com/pingcap/tidb-operator/blob/v1.5.0/pkg/apis/pingcap/v1alpha1/types.go#L287
and
https://github.com/pingcap/tidb-operator/blob/v1.5.0/pkg/apis/pingcap/v1alpha1/types.go#L1074

PS: Kubernetes officially reject the deprecate of nodeSelector, see issue kubernetes/kubernetes#82331

What did you see instead?
Backup spec does not have nodeSelector field, see
https://github.com/pingcap/tidb-operator/blob/v1.5.0/pkg/apis/pingcap/v1alpha1/types.go#L1895-L1992

@yiduoyunQ yiduoyunQ changed the title Backup Backup spec does not has nodeSelector field Oct 9, 2023
@yiduoyunQ yiduoyunQ changed the title Backup spec does not has nodeSelector field Backup spec does not have nodeSelector field Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants